Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

19064: fix the spacing around the input in custom properties right panel #19132

Merged
merged 2 commits into from
Dec 19, 2024
Merged

19064: fix the spacing around the input in custom properties right panel #19132

merged 2 commits into from
Dec 19, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Dec 18, 2024 •
edited
Loading

Describe your changes:

Fixes #19064

  • I worked on fixing the spacing issue around the custom property field in the entity right panel

Previous :

image
Screen.Recording.2024-12-19.at.11.47.56.AM.mov

Resolved :

Screen.Recording.2024-12-18.at.6.41.25.PM.mov
image
Screen.Recording.2024-12-19.at.11.21.27.AM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Dec 18, 2024
@Ashish8689 Ashish8689 self-assigned this Dec 18, 2024
@Ashish8689 Ashish8689 requested a review from a team as a code owner December 18, 2024 13:12
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.88% (40103/62780) 40.43% (16074/39760) 43.08% (4810/11165)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chirag-madlani chirag-madlani merged commit a0c33cc into main Dec 19, 2024
15 of 17 checks passed
@chirag-madlani chirag-madlani deleted the custom-property-spacing-right-panel branch December 19, 2024 06:44
Ashish8689 added a commit that referenced this pull request Dec 19, 2024
@Ashish8689
19064: fix the spacing around the input in custom properties right pa…
912ca63 
…nel (#19132)

* fix the spacing around the input in custom properties right panel

* remove unwanted css

(cherry picked from commit a0c33cc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align the Custom Property Pannel while Editing
3 participants
@Ashish8689 @chirag-madlani @Sachin-chaurasiya